Conversation
PR SummaryThis pull request updates the project by modifying the paths and references to the Quickstart notebook for model documentation. The changes include:
Test Suggestions
|
There was a problem hiding this comment.
I ran the command went through the updated page.
I can see that the Quickstart Notebook option under Validmind library have been changed to Documentation quickstart.
I skimmed through the text and noticed that under the section "Preprocessing the raw dataset", the content I had already reworded for PR 372 appears there. Do I need to include those changes here as well, or can we assume they’ll be merged through that PR?
PR SummaryThis pull request updates the project by modifying the paths and references to the Quickstart notebook for model documentation. The changes involve moving the Test Suggestions
|
|
A PR preview is available: Preview URL |
LoiAnsah
left a comment
There was a problem hiding this comment.
I checked the PR preview and the changes made to "Quickstart for model documentation" were present.
Internal Notes for Reviewers
Note
To test:
gh pr checkout 720cd sitein your terminal to navigate into thesitedirectory where our docs site files live.quarto previewto pull up a live version of the changed site..htmlversion of the new notebook.New Quickstart for model documentation path
Since the path/filename for the model documentation quickstart changed, this PR:
validmind-librarybranch: /beck/sc-7911/edit-code-samples-notebooks-quickstart-forUpdated Makefile
SInce there is now a
quickstartdirectory (as more will live in there), we've removed the Make command within thenotebookscommand to copy out the old file into the root folder.External Release Notes
Taken care of in validmind/validmind-library#372.